Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the config error in restore #2250

Merged
merged 15 commits into from
Apr 24, 2020
Merged

Fix the config error in restore #2250

Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
458dd32
fix the config error in restore
Apr 21, 2020
c7256d4
Update restore.go
Apr 21, 2020
5aaa93e
remove log
Apr 22, 2020
5d60fbd
go fmt
Apr 22, 2020
ee6fe81
revert change
Apr 22, 2020
ffec3c7
address the comment
Apr 22, 2020
411a1aa
Merge branch 'master' into fix_lightning_error
Yisaer Apr 22, 2020
db480be
Update restore.go
Apr 22, 2020
5553d59
add note
Apr 22, 2020
de8af8f
Update restore.go
Apr 22, 2020
ed12786
add logfile
Apr 22, 2020
584b392
Merge branch 'master' into fix_lightning_error
Yisaer Apr 23, 2020
e1be75a
Merge branch 'master' into fix_lightning_error
Yisaer Apr 23, 2020
7cf2825
Merge branch 'master' into fix_lightning_error
Yisaer Apr 23, 2020
b194b2f
Merge branch 'master' into fix_lightning_error
Yisaer Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/backup-manager/app/import/restore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ func (ro *Options) loadTidbClusterData(restorePath string) error {
"--status-addr=0.0.0.0:8289",
"--backend=tidb",
"--server-mode=false",
"–-log-file=",
"--log-file=",
"--tidb-port=4000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ro.Port.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

fmt.Sprintf("--tidb-user=%s", ro.User),
fmt.Sprintf("--tidb-password=%s", ro.Password),
fmt.Sprintf("--tidb-host=%s", ro.Host),
Expand Down