Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: support gcp backup with br #2267

Merged
merged 11 commits into from
May 7, 2020
Merged

backup: support gcp backup with br #2267

merged 11 commits into from
May 7, 2020

Conversation

shuijing198799
Copy link
Contributor

@shuijing198799 shuijing198799 commented Apr 22, 2020 •
edited by DanielZhangQD
Loading

What problem does this PR solve?

support gcp backup with br

What is changed and how does it work?

check bucket and return gcp args for support br backup to gcs

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change
Support backup and restore with GCS using BR

@shuijing198799 shuijing198799 changed the title （WIP）backup: support gcp backup with br （DNM）backup: support gcp backup with br Apr 22, 2020
@shuijing198799 shuijing198799 mentioned this pull request Apr 23, 2020
Closed
4 tasks
@shuijing198799 shuijing198799 changed the title （DNM）backup: support gcp backup with br backup: support gcp backup with br May 6, 2020
@shuijing198799 shuijing198799 requested review from DanielZhangQD, Yisaer and weekface and removed request for DanielZhangQD May 6, 2020 09:20
@DanielZhangQD
Copy link
Contributor

DanielZhangQD commented May 7, 2020 •
edited
Loading

Suggest changes for release notes:

Support backup and restore with GCS using BR

@shuijing198799
Copy link
Contributor Author

Suggest changes for release notes:

Support backup and restore with GCS using BR

done

DanielZhangQD
DanielZhangQD reviewed May 7, 2020
View reviewed changes
cmd/backup-manager/app/util/remote.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/types.go Outdated Show resolved Hide resolved
DanielZhangQD
DanielZhangQD approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuijing198799
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4a644b4 into pingcap:master May 7, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 7, 2020
@shuijing198799 @sre-bot
backup: support gcp backup with br (pingcap#2267)
6377810
@sre-bot sre-bot mentioned this pull request May 7, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented May 7, 2020

cherry pick to release-1.1 in PR #2388

@shuijing198799 shuijing198799 deleted the yinlinag/support-gcp-backup branch May 7, 2020 08:57
sre-bot added a commit that referenced this pull request May 8, 2020
@sre-bot
backup: support gcp backup with br (#2267) (#2388)
3568f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuijing198799 @DanielZhangQD @sre-bot @Yisaer @cofyc