Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto scaler status syncing error #2289

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Fix auto scaler status syncing error #2289

merged 2 commits into from
Apr 26, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Apr 24, 2020 •
edited
Loading

What problem does this PR solve?

Fix the error when syncing tidbclusterautoscaler status, add check whether the target sts is existed.

Does this PR introduce a user-facing change?:

Fix a panic in syncing `TidbClusterAutoScaler` status when the target `TidbCluster` does not exist

@Yisaer Yisaer added type/bug Something isn't working needs-cherry-pick-1.1 area/auto-scaling related to auto-scaling labels Apr 24, 2020
@Yisaer Yisaer requested review from cofyc and DanielZhangQD April 24, 2020 11:27
DanielZhangQD
DanielZhangQD approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer Yisaer requested a review from weekface April 24, 2020 11:35
@cofyc
Copy link
Contributor

cofyc commented Apr 26, 2020

suggested release notes:

Fix a panic in syncing `TidbClusterAutoScaler` status when the target `TidbCluster` does not exist

@Yisaer Yisaer merged commit 510bb9f into pingcap:master Apr 26, 2020
@sre-bot sre-bot mentioned this pull request Apr 26, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2020

cherry pick to release-1.1 in PR #2293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
area/auto-scaling related to auto-scaling needs-cherry-pick-1.1 type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @cofyc @sre-bot @weekface @DanielZhangQD