Add event in webhook #2305
Merged
Add event in webhook #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 26, 2020 21:30
weekface
reviewed
Apr 27, 2020
Co-Authored-By: weekface <weekface@gmail.com>
weekface
previously approved these changes
Apr 27, 2020
pkg/webhook/pod/pods.go
Outdated
| } | ||
|
|
||
| const ( | ||
| stsControllerServiceAccounts = "system:serviceaccount:kube-system:statefulset-controller" | ||
| podDeleteMsgPattern = "pod[%s] deleted" |
There was a problem hiding this comment.
I think the namespace here is not necessary as the event belongs to a certain tidbcluster.
There was a problem hiding this comment.
Then add tc info?
Is the tc info already shown in the event?
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
added 2 commits
April 27, 2020 14:08
added 2 commits
April 27, 2020 14:31
…-operator into add_event_in_webhook
weekface
approved these changes
Apr 27, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
cherry pick to release-1.1 in PR #2311 |
sre-bot
added a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add event in webhook before the pod is admitted to delete. It would help us know the tidbcluster running process when pod admissionwebhook is enabled.
Related changes
Does this PR introduce a user-facing change?: