add cdc types #2338
Merged
add cdc types #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
weekface
force-pushed
the
add-ticdc-types
branch
from
95e85d7 to
5a68ace
Compare
Yisaer
reviewed
Apr 30, 2020
pkg/apis/pingcap/v1alpha1/types.go
Outdated
| @@ -335,6 +339,25 @@ type TiFlashSpec struct { | |||
| LogTailer *LogTailerSpec `json:"logTailer,omitempty"` | |||
| } | |||
|
|
|||
| // TiCdcpec contains details of TiCdc members | |||
| // +k8s:openapi-gen=true | |||
| type TiCdcSpec struct { | |||
There was a problem hiding this comment.
Do we need to add a TidbClusterRef to indicate this TiCDC's target tidbcluster?
There was a problem hiding this comment.
TiCdcSpec is part of TidbCluster, so it doesn't need the TidbClusterRef attribute.
Yisaer
previously approved these changes
May 6, 2020
|
Can we change |
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Yisaer
approved these changes
May 12, 2020
|
/run-e2e-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
May 12, 2020
Merged
|
cherry pick to release-1.1 in PR #2449 |
cofyc
pushed a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add ticdc types. Part of #2056
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: