Skip the TLS of the PD dashboard when the TiDB version < v4.0.0 #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
reviewed
May 7, 2020
Yisaer
reviewed
May 7, 2020
Comment on lines
58
to
65
| func (tc *TidbCluster) PDVersion() string { | ||
| version := tc.Spec.PD.Version | ||
| if version == nil { | ||
| version = &tc.Spec.Version | ||
| } | ||
|
|
||
| return *version | ||
| } |
There was a problem hiding this comment.
I suggest letting pd tell operator the PDVersion (Don't know how or whether it exists) instead of judging it from spec.pd.version as we can't solve the case like version: nightly.
There was a problem hiding this comment.
I don't known how to let pd tell its version before starting it.
cofyc
reviewed
May 7, 2020
cofyc
previously approved these changes
May 7, 2020
|
/run-e2e-tests |
cofyc
approved these changes
May 8, 2020
|
/merge |
|
/run-all-tests |
|
cherry pick to release-1.1 in PR #2401 |
sre-bot
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes: #2385
What is changed and how does it work?
Check List
Tests
Unit test
Code changes
Has Go code change
Side effects
Related changes
Does this PR introduce a user-facing change?: