Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create node pool for tiflash and cdc (#2413) #2419

Merged
merged 1 commit into from
May 11, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 11, 2020

cherry-pick #2413 to release-1.1


What problem does this PR solve?

fix #2376

What is changed and how does it work?

Support creating node pools for tiflash and cdc

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy EKS with the following config, node pools for tiflash and cdc are created successfully and tiflash Pods can be scheduled to the tiflash nodes.
    create_tiflash_node_pool = true
    create_cdc_node_pool = true
    cluster_tiflash_count = 2
    cluster_cdc_count = 2
    cluster_cdc_instance_type = "c5.large"
    cluster_tiflash_instance_type = "c5d.large"
    
    • Deploy EKS with the following config, node pools for tiflash and cdc will not be created.
    #create_tiflash_node_pool = true
    #create_cdc_node_pool = true
    cluster_tiflash_count = 2
    cluster_cdc_count = 2
    cluster_cdc_instance_type = "c5.large"
    cluster_tiflash_instance_type = "c5d.large"
    

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support creating node pools for tiflash and cdc on EKS

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8086912 into pingcap:release-1.1 May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants