Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by removing TidbControl's lock #2489

Merged
merged 4 commits into from
May 20, 2020
Merged

Improve performance by removing TidbControl's lock #2489

merged 4 commits into from
May 20, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented May 18, 2020 •
edited
Loading

What problem does this PR solve?

Now, all controllers use this single tidbConrol instance, this pr remove the mutex to improve performance.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Improve performance by removing TidbControl's lock.

@weekface weekface changed the title remove lock on tidbControl Improve performance by removing TidbControl's lock May 19, 2020
@weekface weekface marked this pull request as ready for review May 19, 2020 03:41
DanielZhangQD
DanielZhangQD approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuijing198799
shuijing198799 approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor

Yisaer commented May 20, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@weekface merge failed.

@weekface
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3e1b7f9 into pingcap:master May 20, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 20, 2020
@weekface @sre-bot
Improve performance by removing TidbControl's lock (pingcap#2489)
52f6eb7
@sre-bot sre-bot mentioned this pull request May 20, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

cherry pick to release-1.1 in PR #2502

sre-bot added a commit that referenced this pull request May 20, 2020
@sre-bot
Improve performance by removing TidbControl's lock (#2489) (#2502)
ed779d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@shuijing198799 shuijing198799 shuijing198799 approved these changes

@Yisaer Yisaer Yisaer approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@aylei aylei Awaiting requested review from aylei

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weekface @Yisaer @sre-bot @shuijing198799 @DanielZhangQD