Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync pump before tidb #2515

Merged
merged 4 commits into from
May 21, 2020
Merged

sync pump before tidb #2515

merged 4 commits into from
May 21, 2020

Conversation

DanielZhangQD
Copy link
Contributor

What problem does this PR solve?

Currently, pump is synced after tidb, there may be following issues:

  • during installation, tidb will fail to start because pump is not running yet
  • during upgrade this may cause issue because new version of tidb may not write old version of pump

TiUP and Ansible also handle pump before tidb.

What is changed and how does it work?

sync pump before tidb

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy TiDB Cluster without pump
    • Deploy TiDB Cluster with pump
    • Upgrade TiDB Cluster without pump
    • Upgrade TiDB Cluster with pump

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Sync Pump before TiDB

@Yisaer
Copy link
Contributor

Yisaer commented May 21, 2020

we can wait #2514 merge then merge this PR.

@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

@Yisaer
Copy link
Contributor

Yisaer commented May 21, 2020

I suggest changing the release notes as

Making `Pump` syncing before `TiDB` component instead of after `TiDB` component.

@Yisaer
Copy link
Contributor

Yisaer commented May 21, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

Your auto merge job has been accepted, waiting for:

  • 2518
  • 2519

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

@DanielZhangQD merge failed.

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

Your auto merge job has been accepted, waiting for:

  • 2508

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

@DanielZhangQD merge failed.

@Yisaer
Copy link
Contributor

Yisaer commented May 21, 2020

/run-e2e-in-kind

@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

@DanielZhangQD
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

/run-all-tests

@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

@sre-bot sre-bot merged commit 08dc79c into pingcap:master May 21, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

cherry pick to release-1.1 in PR #2528

@DanielZhangQD DanielZhangQD deleted the pump branch May 22, 2020 00:43
sre-bot added a commit that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants