Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PD failover (#2570) #2577

Merged
merged 1 commit into from
May 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 28, 2020

cherry-pick #2570 to release-1.1


What problem does this PR solve?

Limit the PD Member in checking PD failover. If the PD Member didn't manage by the operator, the operator wouldn't failover if the unmanaged pd member failed.

Does this PR introduce a user-facing change?:

`Operator` won't failover failed `PD` Member if it didn't be managed by `Operator`.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit ac69a19 into pingcap:release-1.1 May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants