Directly use CRD in e2e test instead of helm (#2545) #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Yisaer
approved these changes
Jun 2, 2020
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2545 to release-1.1
What problem does this PR solve?
Currently, our test code in e2e/stability is based on helm in managing tidbcluster. As CRD is the only tool recommended to manage tidbcluster after operator 1.1.0 released, I think it is necessary to use CRD instead of helm to manage tidbcluster in test. However, the current OperatorActions is based on the helm and it's hard to revise it as it would both influence the e2e test and stabilty test.
As @cofyc commented, the XXXAction is overdesigned and in this request we only using function to manage tidbcluster here.
Does this PR introduce a user-facing change?: