Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add humanreadable backup size #2772

Merged
merged 3 commits into from
Jun 19, 2020
Merged

add humanreadable backup size #2772

merged 3 commits into from
Jun 19, 2020

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Jun 18, 2020 •
edited
Loading

What problem does this PR solve?

Fixes #2634

What is changed and how does it work?

Check List

Tests

  • - Unit test
  • - E2E test
  • - Stability test
  • - Manual test (add detailed scripts or steps below)
  • - No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@DanielZhangQD
Copy link
Contributor 

# k get bk -n ns0 br10        
NAME   BACKUPPATH                     BACKUPSIZE   COMMITTS             AGE
br10   s3://danz-backup10/ns0/br10/   454 kB       417474393989971969   4m
# k get bk -n ns0 -o wide br10
NAME   BACKUPPATH                     BACKUPSIZE   COMMITTS             STARTED                COMPLETED              AGE
br10   s3://danz-backup10/ns0/br10/   454 kB       417474393989971969   2020-06-19T03:47:07Z   2020-06-19T03:47:28Z   4m
# k get bk -n ns0 my03        
NAME   BACKUPPATH                                                BACKUPSIZE   COMMITTS             AGE
my03   s3://danz-backup10/my03/backup-2020-06-19T03:30:37Z.tgz   187 kB       417474134061088772   21m
# k get bk -n ns0 -o wide my03
NAME   BACKUPPATH                                                BACKUPSIZE   COMMITTS             STARTED                COMPLETED              AGE
my03   s3://danz-backup10/my03/backup-2020-06-19T03:30:37Z.tgz   187 kB       417474134061088772   2020-06-19T03:30:37Z   2020-06-19T03:30:45Z   21m

DanielZhangQD
DanielZhangQD approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjj2wry zjj2wry changed the title WIP: add humanreadable backup size add humanreadable backup size Jun 19, 2020
@zjj2wry zjj2wry requested a review from Yisaer June 19, 2020 03:55
@DanielZhangQD
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 2229
  • 2754
  • 2754

@DanielZhangQD
Copy link
Contributor

/run-e2e-tests

@cofyc cofyc mentioned this pull request Jun 19, 2020
Closed
6 tasks
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 26b6d81 into pingcap:master Jun 19, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jun 19, 2020
@ti-srebot
cherry pick pingcap#2772 to release-1.1
368f5f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2778

ti-srebot added a commit that referenced this pull request Jun 19, 2020
@ti-srebot
add humanreadable backup size (#2772) (#2778)
70ac92e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Jiajin Zheng <zhengjiajin@pingcap.com>
@cofyc cofyc mentioned this pull request Jul 1, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use human readable format for backup size
4 participants
@zjj2wry @DanielZhangQD @ti-srebot @Yisaer