Don't initialize when there is no tidb.password #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to some discussion on #274 |
Don't create * a secret * an initializer job The user can manage users from the MySQL connection
|
The related documents should be updated too. |
|
/run-e2e-tests |
|
What are the checkbox meaning? Will you support both of them in this PR? |
|
Yes. It is listing the manual testing cases. Perhaps you want to do the unchecked one? |
|
From #274, we've discussed that it's better to reference secret name created outside of helm. Are you going to do this in another PR or just leave it like this? |
|
secret name references would be a different PR. |
weekface
approved these changes
Feb 26, 2019
shuijing198799
pushed a commit
to shuijing198799/tidb-operator
that referenced
this pull request
Mar 15, 2019
* Don't initialize when there is no tidb.password Don't create * a secret * an initializer job The user can manage users from the MySQL connection * update password documentation
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't create
Motivation
From my reading, random password initialization is broken: helm/helm#3053
The user can manage users from the MySQL connection
As a benefit this allows users manage their password such that it is never stored in K8s. Or they can create their own init job, etc.
Testing
For both options: