Revise interface for the native api in the controller package #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
requested review from
weekface,
cofyc,
zjj2wry,
DanielZhangQD and
lichunzhu
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-e2e-in-kind |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #2824 |
ti-srebot
added a commit
that referenced
this pull request
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
use
runtime.Objectinstead ofTidbClusterfor the native api controller interface so that other controller could use these methods directly.Related changes
Does this PR introduce a user-facing change?: