-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip duplicated e2e case #2825
Merged
Merged
Skip duplicated e2e case #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
requested review from
cofyc,
weekface,
DanielZhangQD,
zjj2wry and
lichunzhu
June 28, 2020 08:45
weekface
approved these changes
Jun 28, 2020
lichunzhu
approved these changes
Jun 28, 2020
/merge |
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-1.1 in PR #2826 |
ti-srebot
added a commit
that referenced
this pull request
Jun 28, 2020
cofyc
reviewed
Jun 30, 2020
@@ -1033,6 +1033,7 @@ var _ = ginkgo.Describe("[tidb-operator][Serial]", func() { | |||
}) | |||
|
|||
ginkgo.It("basic deployment", func() { | |||
framework.Skipf("duplicated test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's duplicated, remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Skip the e2e case
upgrading tidb-operator in the same minor series should not trigger rolling-update
as it have already been covered by the[Verify: Upgrading Operator from 1.1.0]
Related changes
Does this PR introduce a user-facing change?: