Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplicated e2e case #2825

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Skip duplicated e2e case #2825

merged 1 commit into from
Jun 28, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jun 28, 2020

What problem does this PR solve?

Skip the e2e case upgrading tidb-operator in the same minor series should not trigger rolling-update as it have already been covered by the [Verify: Upgrading Operator from 1.1.0]

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 28, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4eefec6 into pingcap:master Jun 28, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2826

ti-srebot added a commit that referenced this pull request Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Song Gao <disxiaofei@163.com>
@@ -1033,6 +1033,7 @@ var _ = ginkgo.Describe("[tidb-operator][Serial]", func() {
})

ginkgo.It("basic deployment", func() {
framework.Skipf("duplicated test")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's duplicated, remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants