Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add v1.1.2 release notes #2842

Merged
merged 4 commits into from
Jul 1, 2020
Merged

add v1.1.2 release notes #2842

merged 4 commits into from
Jul 1, 2020

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jul 1, 2020

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@cofyc cofyc force-pushed the fix2839-release-notes branch from f6a1161 to 1491df1 Compare July 1, 2020 03:41
weekface
weekface previously approved these changes Jul 1, 2020
View reviewed changes
@cofyc cofyc changed the title add v1.1.2 release nots add v1.1.2 release notes Jul 1, 2020
DanielZhangQD
DanielZhangQD reviewed Jul 1, 2020
View reviewed changes
CHANGELOG-1.1.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Jul 1, 2020
View reviewed changes
CHANGELOG-1.1.md Outdated Show resolved Hide resolved
CHANGELOG-1.1.md Outdated Show resolved Hide resolved
@cofyc @DanielZhangQD @ran-huang
Apply suggestions from code review
2640757 
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
ran-huang reviewed Jul 1, 2020
View reviewed changes
CHANGELOG-1.1.md Outdated Show resolved Hide resolved
@cofyc @ran-huang
Apply suggestions from code review
9fc10ad 
Co-authored-by: Ran <huangran@pingcap.com>
@cofyc cofyc mentioned this pull request Jul 1, 2020
Closed
6 tasks
ran-huang
ran-huang previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DanielZhangQD
DanielZhangQD previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc dismissed stale reviews from DanielZhangQD and ran-huang via 78bdc33 July 1, 2020 11:36
@cofyc cofyc merged commit 60cf7d4 into pingcap:master Jul 1, 2020
@cofyc
Copy link
Contributor Author

cofyc commented Jul 1, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jul 1, 2020
@cofyc @ti-srebot
cherry pick pingcap#2842 to release-1.1
3d76fe0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2850

cofyc added a commit that referenced this pull request Jul 1, 2020
@ti-srebot @cofyc
cherry pick #2842 to release-1.1 (#2850)
04c96f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@DanielZhangQD DanielZhangQD DanielZhangQD left review comments

@weekface weekface weekface left review comments

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cofyc @ti-srebot @weekface @DanielZhangQD @ran-huang