Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lightning&br version to v4.0.2 #2865

Merged
merged 3 commits into from
Jul 4, 2020

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jul 3, 2020

What problem does this PR solve?

Resolve #2817.
Current lightning doesn't support auto random.

What is changed and how does it work?

  1. Update lightning&br version to v4.0.2 to support auto random.
  2. Update local-up-operator.sh to support using local backup image.

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)

test with different tidb cluster versions to check whether br/lightning support auto random. Tested versions are v3.1.0, v3.1.2, v4.0.0, v4.0.1

For lightning, all versions can import data both with auto_random and without auto_random successfully.
For br, br can't restore v3.1.0 cluster(I think this is a known issue). The other versions are ok.

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Update the lightning used in tidb-backup-manager from v3.0.15 to v4.0.2

@cofyc
Copy link
Contributor

cofyc commented Jul 3, 2020

can you add the change made in the hack/local-up-operator.sh? (it's also ok if you submit a separate PR)

@lichunzhu
Copy link
Contributor Author

can you add the change made in the hack/local-up-operator.sh? (it's also ok if you submit a separate PR)

added in this PR

@Yisaer Yisaer merged commit 0a1f2bf into pingcap:master Jul 4, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Jul 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #2866

ti-srebot added a commit that referenced this pull request Jul 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@lichunzhu lichunzhu deleted the updateLightningVersion branch September 2, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the lightning version in the backup-manager to support auto-random
4 participants