-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure SLOW_LOG_FILE env variable is always set #298
Conversation
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
/run-e2e-tests |
/run-e2e-tests |
I think you should move #297 codes to this PR, or we can't confirm this PR can work as expected without the e2e tests. |
Signed-off-by: Aylei <rayingecho@gmail.com>
/run-e2e-tests |
2 similar comments
/run-e2e-tests |
/run-e2e-tests |
I rebuilt the dind env. You should rerun the e2e after this job is completed: https://internal.pingcap.net/jenkins/job/rebuild_k8s_dind_test_env/82/ |
/run-e2e-tests |
ping @tennix @xiaojingchen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* cdc document * Update zh/deploy-ticdc.md Co-authored-by: Ran <huangran@pingcap.com> * address comments * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
close #295
Signed-off-by: Aylei rayingecho@gmail.com