use a generic way to test methods of PD Client #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
commented
Jul 20, 2020
| @@ -22,12 +22,6 @@ import ( | |||
| "k8s.io/klog" | |||
| ) | |||
|
|
|||
| const ( | |||
| @@ -0,0 +1,252 @@ | |||
| // Copyright 2020 PingCAP, Inc. | |||
There was a problem hiding this comment.
move the faked version of PD API to a separate file
| @@ -0,0 +1,135 @@ | |||
| // Copyright 2018 PingCAP, Inc. | |||
There was a problem hiding this comment.
move PD control interface to a separate file
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
+ Coverage 41.01% 41.41% +0.39%
==========================================
Files 153 155 +2
Lines 16751 16744 -7
==========================================
+ Hits 6871 6934 +63
+ Misses 9333 9250 -83
- Partials 547 560 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-srebot
approved these changes
Jul 20, 2020
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #2994 |
cofyc
added a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#2939
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: