Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the SLOW_LOG_FILE in the startup script #307

Merged
merged 3 commits into from
Mar 14, 2019
Merged

set the SLOW_LOG_FILE in the startup script #307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e21d4f7
set the SLOW_LOG_FILE in the startup script
gregwebs Mar 11, 2019
6957832
Merge branch 'master' into startup-script-set-SLOW_LOG_FILE
gregwebs Mar 12, 2019
6d97425
Merge branch 'master' into startup-script-set-SLOW_LOG_FILE
tennix Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/tidb-cluster/templates/scripts/_start_tidb.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ then
ARGS="${ARGS} --enable-binlog=true"
fi

SLOW_LOG_FILE=${SLOW_LOG_FILE:-""}
if [[ ! -z "${SLOW_LOG_FILE}" ]]
then
ARGS="${ARGS} --log-slow-query=${SLOW_LOG_FILE:-}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to have ${SLOW_LOG_FILE:-} after setting it on line 37 and checking it on line 38?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 38 it will be undefined. The purpose of line 37 is just to define it and set a default value if it is not defined. It is a little verbose and obscure as bash is, but I think this idiom is easy to get used to and understand whereas the other ones are trickier. And overall it is much safer to use these techniques and have undefined variables be an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so I think you are more directly asking about :-. That allows for the variable to be unset and not throw an undefined variable error.

${parameter:-word}
    If parameter is unset or null, the expansion of word is substituted. 
    Otherwise, the value of parameter is substituted.

Expand Down