Add support for max-index-length to TidbCluster CRD #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3076 +/- ##
=======================================
Coverage 42.35% 42.35%
=======================================
Files 156 156
Lines 16767 16767
=======================================
Hits 7102 7102
Misses 9092 9092
Partials 573 573
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@kolbe Please run |
cofyc
approved these changes
Aug 7, 2020
ti-srebot
approved these changes
Aug 7, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Aug 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #3087 |
ti-srebot
added a commit
that referenced
this pull request
Aug 7, 2020
* cherry pick #3076 to release-1.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * update crd Co-authored-by: Kolbe Kegel <kolbe@pingcap.com> Co-authored-by: DanielZhangQD <zhanghailong810@aliyun.com> Co-authored-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #3075
What is changed and how does it work?
Add max-index-length to TidbCluster and TiDBGroup in manifests/crd.yaml, and add MaxIndexLength to tidb_config.go.
Check List
Tests
I was able to successfully add max-index-length to the config in TidbCluster and have it applied to nodes in the cluster.
Code changes
Side effects
n/a
Related changes
Does this PR introduce a user-facing change?: