-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix goroutine leak when tls enabled #3081
Conversation
Deploy 4 TiDB Clusters with TLS enabled and 4 TiDB Clusters with TLS disabled, after 12 hours running with this fix:
The memory usage is less than 60 MB and the heap profile as below:
|
Codecov Report
@@ Coverage Diff @@
## master #3081 +/- ##
==========================================
- Coverage 42.34% 42.33% -0.02%
==========================================
Files 156 156
Lines 16763 16767 +4
==========================================
Hits 7099 7099
- Misses 9091 9094 +3
- Partials 573 574 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-1.1 in PR #3083 |
What problem does this PR solve?
Fix #3079
What is changed and how does it work?
Disable keepalive for TLS connections, more detail refer to elastic/cloud-on-k8s#854 (comment)
Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: