backup: TLS Support for Backup&Restore with dumpling&lightning #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
force-pushed
the
supportTLSForBackupManager
branch
from
ecd2a34 to
266b23c
Compare
cofyc
previously approved these changes
Aug 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
- Coverage 42.95% 42.84% -0.12%
==========================================
Files 155 155
Lines 16780 16828 +48
==========================================
+ Hits 7208 7210 +2
- Misses 8962 9008 +46
Partials 610 610
Flags with carried forward coverage won't be shown. Click here to find out more. |
ti-srebot
approved these changes
Aug 13, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Aug 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #3104 |
ti-srebot
added a commit
that referenced
this pull request
Aug 14, 2020
#3104) Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resolve #3094
dumpling and lightning have already supported tls but tidb-operator don't use the configs.
What is changed and how does it work?
Add tls configs for lightning&dumpling in tidb-operator.
Check List
Tests
Manually test dumpling&lightning for tidb cluster.
Code changes
Related changes
Does this PR introduce a user-facing change?: