log dump when test failed #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojingchen
changed the title
weekface
reviewed
Mar 14, 2019
tests/cmd/e2e/main.go
Outdated
| @@ -53,9 +53,11 @@ func main() { | |||
| LogLevel: "2", | |||
| } | |||
| if err := oa.CleanOperator(operatorInfo); err != nil { | |||
| oa.DumpAllLogs(operatorInfo, []*tests.TidbClusterInfo{}) | |||
There was a problem hiding this comment.
Suggested change
| oa.DumpAllLogs(operatorInfo, []*tests.TidbClusterInfo{}) | |
| oa.DumpAllLogs(operatorInfo, nil) |
tests/cmd/e2e/main.go
Outdated
| glog.Fatal(err) | ||
| } | ||
| if err := oa.DeployOperator(operatorInfo); err != nil { | ||
| oa.DumpAllLogs(operatorInfo, []*tests.TidbClusterInfo{}) |
There was a problem hiding this comment.
Suggested change
| oa.DumpAllLogs(operatorInfo, []*tests.TidbClusterInfo{}) | |
| oa.DumpAllLogs(operatorInfo, nil) |
zyguan
reviewed
Mar 14, 2019
tests/log_dump.go
Outdated
| if err != nil { | ||
| writer.WriteString(err.Error()) | ||
| } | ||
| writer.WriteString(string(data)) |
There was a problem hiding this comment.
data might be nil, however it's unnecessary if you set writer as stdout & stderr.
xiaojingchen
force-pushed
the
xiaojingchen/log-dump
branch
from
81c31ed to
d1038cf
Compare
| } | ||
|
|
||
| func dumpPod(logPath string, pod *corev1.Pod) error { | ||
| logFile, err := os.Create(filepath.Join(logPath, fmt.Sprintf("%s-%s.log", pod.Name, pod.Namespace))) |
There was a problem hiding this comment.
log file name generate rule may resulting in the log generated during the second run will overwrite the first run
|
@xiaojingchen Please resolve the conflicts. |
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* add log dump
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weekface @cwen0 @zyguan @shuijing198799 PTAL