refactor stability main function #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
xiaojingchen
reviewed
Apr 3, 2019
| } | ||
| fta.StartNodeOrDie(physicalNode, node) | ||
| for _, cluster := range allClusters { | ||
| oa.CheckTidbClusterStatusOrDie(cluster) |
There was a problem hiding this comment.
there need to check recover
|
/run-e2e-tests |
xiaojingchen
previously approved these changes
Apr 3, 2019
|
@tennix @onlymellb PTAL |
zyguan
reviewed
Apr 4, 2019
tests/actions.go
Outdated
| CreateSecret(info *TidbClusterConfig) error | ||
| GetPodUIDMap(info *TidbClusterConfig) (map[string]types.UID, error) | ||
| GetNodeMap(info *TidbClusterConfig, component string) (map[string][]string, error) | ||
| getBackupDir(info *TidbClusterConfig) ([]string, error) |
There was a problem hiding this comment.
Others cannot implement the interface due to this private method.
weekface
commented
Apr 4, 2019
xiaojingchen
approved these changes
Apr 4, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add cdc document * Update zh/deploy-on-alibaba-cloud.md Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.