dashboard:update editable value from true to false #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojingchen
previously approved these changes
Apr 16, 2019
|
/run-e2e-tests |
tennix
previously approved these changes
Apr 17, 2019
|
/run-e2e-tests |
|
please run |
|
/run-e2e-tests |
weekface
approved these changes
Apr 18, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* pv offline doc * Update zh/configure-storage-class.md Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
Grafana allow to edit dashboard as default value.
For these dashboards which are provided with provisioning way, It is better not to let users edit by default.
So in this PR, just update the editable value from true to fase
Test
There is no delete button, customer can enable it in settings page.