Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Update AWS ELB config #3974

Merged
merged 2 commits into from
May 18, 2021
Merged

examples: Update AWS ELB config #3974

merged 2 commits into from
May 18, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 14, 2021 •
edited
Loading

What problem does this PR solve?

  • Remove incorrect aws-load-balancer-internal.
  • Change the loadbalancer for Grafana from "CLB" (Classic) to "NLB"
    (Network)

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Deploy on EKS with https://docs.pingcap.com/tidb-in-kubernetes/stable/deploy-on-aws-eks

On the AWS Console check the loadbalancers that were created. This should show three NLB type loadbalancers with the 'internet facing' scheme. Previously this would show 1 NLB and 1 CLB and the NLB had the 'internal' scheme.

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@CLAassistant
Copy link

CLAassistant commented May 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from Yisaer May 14, 2021 07:17
@dveeden
Copy link
Contributor Author

dveeden commented May 14, 2021 •
edited
Loading

Should we also add a LoadBalancer for PD as that is hosting the dashboard on port 2379?

update: I did add a LB for this.

@dveeden dveeden force-pushed the examples_aws_nlb branch from 77a54dc to 386f4d6 Compare May 14, 2021 07:42
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021 •
edited
Loading

Codecov Report

Merging #3974 (4ce5f47) into master (a015396) will increase coverage by 6.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3974      +/-   ##
==========================================
+ Coverage   61.94%   68.81%   +6.87%     
==========================================
  Files         173      177       +4     
  Lines       18345    18847     +502     
==========================================
+ Hits        11364    12970    +1606     
+ Misses       5866     4750    -1116     
- Partials     1115     1127      +12
Flag Coverage Δ
e2e 48.77% <ø> (?)
unittest 61.96% <ø> (+0.01%) ⬆️

DanielZhangQD
DanielZhangQD reviewed May 17, 2021
View reviewed changes
examples/aws/tidb-cluster.yaml Outdated Show resolved Hide resolved
examples/aws/tidb-cluster.yaml Outdated Show resolved Hide resolved
examples/aws/tidb-monitor.yaml Outdated Show resolved Hide resolved
@dveeden dveeden force-pushed the examples_aws_nlb branch from 386f4d6 to 77a80bf Compare May 17, 2021 06:20
@dveeden dveeden mentioned this pull request May 17, 2021
Merged
7 tasks
@dveeden
examples: Update AWS ELB config
77e1bea 
- Remove incorrect `aws-load-balancer-internal`.
- Change the loadbalancer for Grafana from "CLB" (Classic) to "NLB"
  (Network)
@dveeden dveeden force-pushed the examples_aws_nlb branch from 77a80bf to 77e1bea Compare May 17, 2021 08:57
@dveeden dveeden requested a review from DanielZhangQD May 17, 2021 08:57
DanielZhangQD
DanielZhangQD approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • july2993

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ce5f47

@dveeden
Copy link
Contributor Author

dveeden commented May 18, 2021

/run-integration-test

@dveeden
Copy link
Contributor Author

dveeden commented May 18, 2021

/test all

@july2993
Copy link
Contributor

/run-all-tests

1 similar comment
@dveeden
Copy link
Contributor Author

dveeden commented May 18, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 8cf21d8 into pingcap:master May 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2021
Merged
7 tasks
@Joyinqin Joyinqin mentioned this pull request May 28, 2021
Merged
8 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request May 31, 2021
Merged
8 tasks
mianhk pushed a commit to mianhk/tidb-operator that referenced this pull request Jul 23, 2021
@dveeden @mianhk
examples: Update AWS ELB config (pingcap#3974)
a97091d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@july2993 july2993 july2993 approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dveeden @CLAassistant @codecov-commenter @ti-chi-bot @DanielZhangQD @july2993