Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub templates for issue reporting and PR #420

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

tennix
Copy link
Member

@tennix tennix commented Apr 23, 2019

GitHub allows a repository to create issue templates and PR template under the .github directory. This PR adds some templates for issue reporting and PR. It should help users, contributors and ourselves to communicate more efficiently.

.github/ISSUE_TEMPLATE/question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question.md Outdated Show resolved Hide resolved
- Searched open and closed [GitHub issues](https://github.com/pingcap/tidb-operator/issues?utf8=%E2%9C%93&q=is%3Aissue)
- Read the documentation:
- [TiDB Operator Readme](https://github.com/pingcap/tidb-operator)
- [TiDB Operator Doc](https://github.com/pingcap/tidb-operator/tree/master/docs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being moved soon?

Copy link
Member Author

@tennix tennix Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll recently move our documents to https://github.com/pingcap/docs and https://github.com/pingcap/docs-cn to make our documents available on PingCAP official website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this link will break?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the links when our documents are all moved to the pingcap/docs and pingcap/docs-cn.

.github/pull_request_template.md Outdated Show resolved Hide resolved
gregwebs
gregwebs previously approved these changes Apr 24, 2019
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 7f1ac2b into pingcap:master Apr 26, 2019
@tennix tennix deleted the github-template branch November 12, 2019 07:15
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* tidb cluster offline installazation

* address comment

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants