Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slack notify #439

Merged
merged 9 commits into from
May 5, 2019
Merged

Conversation

xiaojingchen
Copy link
Contributor

What problem does this PR solve?

solve the problem that stability test lack notify feature

What is changed and how it works?

this pr will notify the particular slack channel when stability test failed or complete

Check List

Tests

  • Stability test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change
  • Has stability test's yaml file change

@weekface weekface requested review from weekface, shuijing198799 and tennix and removed request for weekface May 1, 2019 00:20
@weekface weekface added the test/stability stability tests label May 1, 2019
@weekface
Copy link
Contributor

weekface commented May 1, 2019

/run-e2e-tests

weekface
weekface previously approved these changes May 1, 2019
tennix
tennix previously approved these changes May 1, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewResponse.Allowed = true
return &reviewResponse
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you move this logic into tidb only. this is a common logic for tidb tikv and pd.

@xiaojingchen xiaojingchen dismissed stale reviews from tennix and weekface via 6cee63b May 5, 2019 03:20
@xiaojingchen
Copy link
Contributor Author

fixed some bugs @shuijing198799 @weekface PTAL

1 similar comment
@xiaojingchen
Copy link
Contributor Author

fixed some bugs @shuijing198799 @weekface PTAL

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 712002e into pingcap:master May 5, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/stability stability tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants