Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump operator to v1.2.7 #4422

Merged
merged 1 commit into from
Feb 17, 2022
Merged

bump operator to v1.2.7 #4422

merged 1 commit into from
Feb 17, 2022

Conversation

just1900
Copy link
Contributor

@just1900 just1900 commented Feb 16, 2022

What problem does this PR solve?

bump operator to v1.2.7

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@just1900 just1900 mentioned this pull request Feb 16, 2022
9 tasks
TIDB_OLD="v5\.3\.0"
TIDB_NEW="v5\.4\.0"
DM_OLD="v5.3.0"
DM_NEW="v5.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update the version of TiDB and DM since TiDB Operator v1.2 only supports up to TiDB v5.3 and v5.3.0 is the latest version.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@just1900 just1900 changed the title bump operator to v1.2.7, tidb components and dm to v5.4.0 bump operator to v1.2.7 Feb 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #4422 (893bc6b) into release-1.2 (024c52d) will increase coverage by 5.74%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.2    #4422      +/-   ##
===============================================
+ Coverage        61.54%   67.28%   +5.74%     
===============================================
  Files              181      185       +4     
  Lines            19278    21614    +2336     
===============================================
+ Hits             11864    14544    +2680     
+ Misses            6262     5816     -446     
- Partials          1152     1254     +102     
Flag Coverage Δ
e2e 45.70% <ø> (?)
unittest 61.54% <ø> (ø)

@KanShiori
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 893bc6b

@ti-chi-bot ti-chi-bot merged commit 7a13ac9 into pingcap:release-1.2 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants