docs/dind: update documentation of DinD installation #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* specify full path of template file * update commands and outputs
|
|
tennix
reviewed
May 7, 2019
tennix
reviewed
May 7, 2019
tennix
reviewed
May 7, 2019
| @@ -85,17 +86,17 @@ demo-tidb-peer ClusterIP None <none> 10080/TCP | |||
| demo-tikv-peer ClusterIP None <none> 20160/TCP 1m | |||
|
|
|||
| $ kubectl get configmap -n tidb | |||
There was a problem hiding this comment.
The output needs to be adjusted because of #435
There was a problem hiding this comment.
The output of configmap has no difference with the one currently in doc.
tennix
reviewed
May 7, 2019
tennix
reviewed
May 7, 2019
docs/local-dind-tutorial.md
Outdated
| @@ -37,16 +45,9 @@ $ KUBE_REPO_PREFIX=uhub.ucloud.cn/pingcap manifests/local-dind/dind-cluster-v1.1 | |||
|
|
|||
| ## Step 2: Install TiDB Operator in the DinD Kubernetes cluster | |||
|
|
|||
| Uncomment the `scheduler.kubeSchedulerImage` in `values.yaml`, set it to the same as your kubernetes cluster version. | |||
| Uncomment the `scheduler.kubeSchedulerImage` in `charts/tidb-operator/values.yaml`, set it to desired version if needed, it is default to matching your kubernetes cluster version. | |||
There was a problem hiding this comment.
With line 52, changing the values.yaml is unnecessary.
lilin90
reviewed
May 8, 2019
docs/local-dind-tutorial.md
Outdated
| - [Helm Client](https://github.com/helm/helm/blob/master/docs/install.md#installing-the-helm-client): 2.9.0 or later | ||
| - [Kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl): 1.10 or later | ||
| - [Kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl): at least 1.10 required, 1.13 or later recommended |
There was a problem hiding this comment.
This is confusing. Could you make it clearer? Do you mean 1.10, 1.13 or later?
There was a problem hiding this comment.
At least 1.10 is required to work, but we recommend users to use 1.13 or later for best compatibility.
docs/local-dind-tutorial.md
Outdated
|
|
||
| In this sample output, the ports are: 32503 for Grafana, 32448 for Prometheus, and 32714 for TiDB. | ||
|
|
||
| 2. Find host IP address of the cluster. |
There was a problem hiding this comment.
Suggested change
| 2. Find host IP address of the cluster. | |
| 2. Find the host IP address of the cluster. |
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
Co-Authored-By: AstroProfundis <allen@moe.cat>
AstroProfundis
changed the title
AstroProfundis
changed the title
lilin90
reviewed
May 9, 2019
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Testing current documentation of DinD installation and keep it up to date.
What is changed and how it works?
Tested all instructions in the DinD installation documentation on CentOS 7 and latest ArchLinux VMs, updated them to fit testing results and added some detailed notes.
Check List
Tests
Code changes
Side effects
Related changes