Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliyun tf output rendering and refine documents #511

Merged
merged 7 commits into from
May 30, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented May 23, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

Fix the output render error when kubernetes is not successfully created in aliyun.

What is changed and how it works?

TF scripts changed.

Check List

Tests

  • Manual test (Passed)

@AstroProfundis @tennix @IzabelWang PTAL

… refine documents

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
tennix
tennix previously approved these changes May 27, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented May 29, 2019

@tennix Thanks for your review, I've fix a merge conflict just now, could you please take a look again?

@aylei aylei requested a review from tennix May 29, 2019 04:10
@aylei
Copy link
Contributor Author

aylei commented May 29, 2019

/run-e2e-tests

Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented May 29, 2019

/run-e2e-tests

@aylei
Copy link
Contributor Author

aylei commented May 29, 2019

/run-e2e-tests

1 similar comment
@aylei
Copy link
Contributor Author

aylei commented May 30, 2019

/run-e2e-tests

@aylei
Copy link
Contributor Author

aylei commented May 30, 2019

/run-e2e-tests

@aylei
Copy link
Contributor Author

aylei commented May 30, 2019

/run-e2e-tests

@aylei aylei merged commit 425143a into pingcap:master May 30, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* Add telemetry notes

* 理解和改善产品 -> 改善产品

* Add EN doc

* Fix some links

* Address comments

* Sync changes from CN doc

* Sync changes from docs

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants