GKE terraform #585
Merged
GKE terraform #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregwebs
commented
Jun 15, 2019
gregwebs
commented
- use gcloud CLI to automate service account provisioning
- provide option to use small instances or prod instances
- local-exec scripts: add set -e and make idempotent
- use data.google_compute_zones.available.names to prevent bastion re-creation
* use gcloud CLI for service account provisioning * provide option to use small instances or prod instances * local-exec scripts: add set -e and make idempotent
tennix
reviewed
Jun 17, 2019
tennix
reviewed
Jun 17, 2019
| } | ||
|
|
||
| provisioner "local-exec" { | ||
| interpreter = ["bash", "-c"] | ||
| command = <<EOS |
There was a problem hiding this comment.
Use EOT instead of EOS to make Terraform 0.12 format this correctly.
There was a problem hiding this comment.
any word will work here.
tennix
reviewed
Jun 17, 2019
tennix
reviewed
Jun 17, 2019
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
jlerche
previously approved these changes
Jun 17, 2019
add DEBIAN_FRONTEND=noninteractive this is still needed even when using -y add dpkg configure -a which can be needed
The local volume provisioner startup can take some time
jlerche
previously approved these changes
Jun 18, 2019
|
Also added:
|
jlerche
approved these changes
Jun 18, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.