Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: segmentation fault when backup user's password is empty #649

Merged
merged 6 commits into from
Jul 11, 2019
Merged

bugfix: segmentation fault when backup user's password is empty #649

merged 6 commits into from
Jul 11, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jul 10, 2019 •
edited
Loading

What problem does this PR solve?

fixes: #643
#634

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

fix scheduled backup bug: segmentation fault when backup user's password is empty

@weekface weekface changed the title Fix scheduled backup when password is empty bugfix: segmentation fault when backup user's password is empty Jul 10, 2019
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface marked this pull request as ready for review July 11, 2019 03:05
@weekface weekface requested review from LinuxGit, tennix and aylei July 11, 2019 03:05
aylei
aylei approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LinuxGit
LinuxGit approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 8e8807a into pingcap:master Jul 11, 2019
@weekface weekface deleted the fix-scheduled-backup branch July 11, 2019 08:42
@weekface weekface mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@LinuxGit LinuxGit LinuxGit approved these changes

@tennix tennix Awaiting requested review from tennix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduled-backup: segmentation fault when backup user's password is empty
4 participants
@weekface @LinuxGit @xiaojingchen @aylei