Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the default storage size for pump from 10Gi to 20Gi #657

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

sokada1221
Copy link
Contributor

What problem does this PR solve?

#656

What is changed and how does it work?

values.yaml from TiDB cluster helm chart is updated

The default storage size for pump services is increased from 10GiB to 20GiB because pump introduced a new configuration stop-write-at-available-space, which comes with a default value of 10GiB. Deploying with the old default storage size, 10GiB, immediately results in no available space error in pump services.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Deploy TiDB operator and cluster with the updated helm charts to AWS

Code changes

  • Has Helm charts change

Side effects

  • N/A

Related changes

  • N/A

Does this PR introduce a user-facing change?:

NONE

@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@aylei
Copy link
Contributor

aylei commented Jul 14, 2019

/ok-to-test

@aylei
Copy link
Contributor

aylei commented Jul 14, 2019

/run-e2e-tests

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 4465e97 into pingcap:master Jul 15, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
…nse to stop-write-at-available-space (#657)

(cherry picked from commit 4465e97)
@sokada1221 sokada1221 deleted the increase-pump-defualt-storage branch August 22, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants