limit test cover packages #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlymellb
approved these changes
Jul 24, 2019
|
/run-e2e-test |
weekface
reviewed
Jul 24, 2019
| @@ -22,6 +22,7 @@ filenametags | |||
| *.coverprofile | |||
|
|
|||
| coverage.txt | |||
| coverage.out | |||
There was a problem hiding this comment.
where does this file come from?
There was a problem hiding this comment.
run go tool cover -V -func=coverage.txt -o coverage.out will create a file which named coverage.out
weekface
approved these changes
Jul 24, 2019
weekface
pushed a commit
that referenced
this pull request
Jul 29, 2019
* limit test cover packages * remove coverage.out (cherry picked from commit 0f253d7)
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add tag-check scripts; fix some inline codes * test ci * Revert "test ci" This reverts commit 24358ce98b983096d7565a2672beb54d30f8726b. * Update check-tags.py * Update ci.yaml * test ci * make an exit * exit 1 * Update check-tags.py * Revert "test ci" This reverts commit 8427ac09a97820547b6f103ccdd0374aae6eb67d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current unit test cover generated codes and client codes, that influencing real test coverage.
this PR limit the unit test cover packages.
What is changed and how does it work?
make testgo tool cover -V -func=coverage.txt -o coverage.out && cat coverage.outafter limit the cover packages the test coverage increased from 61.4% to 74.3%
Check List
Code changes
Side effects
Does this PR introduce a user-facing change?:
@onlymellb @tennix @weekface PTAL