Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify tikv status address to fix monitoring #695

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jul 26, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

TiKV metrics port cannot be accessed from Prometheus by default.

Also, we have to notice users to keep this configuration when they customize the tikv.config

What is changed and how does it work?

Specify the tikv metrics listen address as 0.0.0.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Fix TiKV metrics monitoring in default setup.

@tennix @DanielZhangQD @weekface PTAL

Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 98d367e into pingcap:master Jul 26, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
(cherry picked from commit 98d367e)
@DanielZhangQD DanielZhangQD mentioned this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants