-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add retry logic for LabelNodes function #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-e2e-in-kind |
1 similar comment
/run-e2e-in-kind |
xiaojingchen
changed the title
[WIP]add retry logic for NodeLable function
e2e: add retry logic for LabelNodes function
Aug 8, 2019
/run-e2e-tests |
/run-e2e-tests |
/run-e2e-test |
/run-e2e-in-kind |
weekface
approved these changes
Aug 9, 2019
@cofyc @shuijing198799 PTAL |
/run-e2e-in-kind |
tennix
approved these changes
Aug 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-1.0 in PR #754 |
xiaojingchen
pushed a commit
that referenced
this pull request
Aug 12, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resolve bug that once label node failed cause e2e failed
What is changed and how does it work?
add retry logic for LabelNodes function
Check List
Tests
Code changes
Does this PR introduce a user-facing change?:
NONE