-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy, manifests: enable cloud storage volume expansion & label local volume #772
Conversation
/run-e2e-in-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW, I suppose we should document the extra works if the user want to expand the volume size of PVCs managed by StatefulSet.
deploy/modules/aws/tidb-operator/manifests/local-volume-provisioner.yaml
Show resolved
Hide resolved
Currently we migrate from Retain to Delete. Can we still do this? |
No, but for tidb-operator managed PVC, the reclaim policy was reset to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll send a PR to add the document to docs and docs-cn later. |
cherry pick to release-1.0 in PR #781 |
run: find . -type file | xargs gsed -i "s/v1\.1\.5/v1\.1\.6/g" check and revert some wrongly update
What problem does this PR solve?
What is changed and how does it work?
Cloud storage volume expansion is enabled by default. Hostname label will be attached to local PV.
Check List
Tests
allowVolumeExpansion
attribute can be updated in-place bykubectl edit sc ebs-gp2
to addallowVolumeExpansion: true
allowVolumeExpansion: true
, updating PVC with larger storage size, the corresponding PV will be expanded to the desired size.reclaimPolicy
can not be changed dynamically. So old gke persistent disk storage class cannot migrate toRetain
.Code changes
Side effects
None
Related changes
Does this PR introduce a user-facing change?: