Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy, manifests: enable cloud storage volume expansion & label local volume #772

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

tennix
Copy link
Member

@tennix tennix commented Aug 15, 2019

What problem does this PR solve?

What is changed and how does it work?

Cloud storage volume expansion is enabled by default. Hostname label will be attached to local PV.

Check List

Tests

  • Manual test
    1. Cloud provider storage class allowVolumeExpansion attribute can be updated in-place by kubectl edit sc ebs-gp2 to add allowVolumeExpansion: true
    2. After adding allowVolumeExpansion: true, updating PVC with larger storage size, the corresponding PV will be expanded to the desired size.
    3. The storage class reclaimPolicy can not be changed dynamically. So old gke persistent disk storage class cannot migrate to Retain.

Code changes

  • Has volume setup change

Side effects

None

Related changes

  • Need to cherry-pick to the release-1.0 branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Users can now expand cloud storage PV dynamically by increasing PVC storage size.

@tennix tennix requested review from gregwebs, cofyc and aylei August 15, 2019 01:27
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2019

CLA assistant check
All committers have signed the CLA.

@weekface
Copy link
Contributor

/run-e2e-in-kind

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
BTW, I suppose we should document the extra works if the user want to expand the volume size of PVCs managed by StatefulSet.

@gregwebs
Copy link
Contributor

The storage class reclaimPolicy can not be changed dynamically. So old gke persistent disk storage class cannot migrate to Retain

Currently we migrate from Retain to Delete. Can we still do this?

@tennix
Copy link
Member Author

tennix commented Aug 16, 2019

The storage class reclaimPolicy can not be changed dynamically. So old gke persistent disk storage class cannot migrate to Retain

Currently we migrate from Retain to Delete. Can we still do this?

No, but for tidb-operator managed PVC, the reclaim policy was reset to Retain by default no matter what is the storage class's default reclaim policy. And the existing PV can be patched to use Retain.

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member Author

tennix commented Aug 16, 2019

LGTM
BTW, I suppose we should document the extra works if the user want to expand the volume size of PVCs managed by StatefulSet.

I'll send a PR to add the document to docs and docs-cn later.

@tennix tennix merged commit 3045bfe into pingcap:master Aug 16, 2019
@tennix tennix deleted the enable-volume-expansion branch August 16, 2019 07:59
@sre-bot
Copy link
Contributor

sre-bot commented Aug 16, 2019

cherry pick to release-1.0 in PR #781

yahonda pushed a commit that referenced this pull request Dec 27, 2021
run:
find . -type file | xargs gsed -i "s/v1\.1\.5/v1\.1\.6/g"

check and revert some wrongly update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants