chart: add important parameters to tikv and tidb config #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add move `status-addr` to start script
charts/tidb-cluster/values.yaml
Outdated
| # # sync-log = true | ||
| # # apply-pool-size = 2 | ||
| # # store-pool-size = 2 | ||
| # shared = true |
There was a problem hiding this comment.
What if users deploy TiDB cluster of v2.x with this chart?
charts/tidb-cluster/values.yaml
Outdated
| @@ -258,7 +223,11 @@ tidb: | |||
| config: | | |||
| [log] | |||
| level = "info" | |||
|
|
|||
| # # Here are some parameters you MUST to customize (Please configure in the above 'tidb.config' section): | |||
weekface
force-pushed
the
fix-tikv-config-doc
branch
from
2742e10 to
756ac08
Compare
|
@aylei @DanielZhangQD PTAL again. |
|
/run-e2e-in-kind |
|
/run-e2e-test |
|
cherry pick to release-1.0 in PR #810 |
weekface
pushed a commit
that referenced
this pull request
Aug 23, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* Add conflicts check and test files * delete test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
status-addrto start scriptWhat is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: