use mdadm instead of LVM if it is available #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
reviewed
Aug 20, 2019
| devs=$(echo "$ssd_mounts" | awk '{print $2}') | ||
| raid_dev=/dev/md0 | ||
|
|
||
| # If RAID or LVM is already in use, this may have been re-deployed. |
There was a problem hiding this comment.
When USE_LVM is changed from 1 to 0, will combined disks with mdadm be wiped?
There was a problem hiding this comment.
The disks would never be wiped again if the write to /var/dev_wiped/ is persisted. But this comment is to indicate that if we detect an existing LVM or RAID setup then don't go down this path where we wipe the disks.
The design of the script is that it to detect if it already ran and to never change what it has already done. So if you change to USE_LVM=1 that will effectively be ignored if the raid device has already been created.
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local-volume-provisioner for GKE. Use mdadm in preference to LVM. Initial tests indicate this may perform better. This only works on Ubuntu. COS for GKE 1.14 is suppose to support RAID, but the mdadm binary is not there yet.
This has been tested on GKE to work on both COS and Ubuntu.