Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean pod schedule annotation #790

Merged
merged 10 commits into from
Sep 12, 2019
Merged

Clean pod schedule annotation #790

merged 10 commits into from
Sep 12, 2019

Conversation

onlymellb
Copy link
Contributor

@onlymellb onlymellb commented Aug 20, 2019 •
edited by tennix
Loading

What problem does this PR solve?

fix #268

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

None

@onlymellb
Copy link
Contributor Author

/run-e2e-test

@onlymellb
Copy link
Contributor Author

/run-e2e-test

weekface
weekface reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/manager/member/pvc_cleaner.go Outdated Show resolved Hide resolved
pkg/scheduler/predicates/ha.go Outdated Show resolved Hide resolved
@onlymellb
Copy link
Contributor Author

/run-e2e-test

weekface
weekface previously approved these changes Aug 22, 2019
View reviewed changes
xiaojingchen
xiaojingchen previously approved these changes Aug 28, 2019
View reviewed changes
@tennix
Copy link
Member

tennix commented Sep 1, 2019 •
edited
Loading

This PR does not have user facing changes, so I'll remove the release note.

@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

@onlymellb onlymellb dismissed stale reviews from xiaojingchen and weekface via af3c451 September 3, 2019 15:02
@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

@onlymellb onlymellb merged commit 084d181 into pingcap:master Sep 12, 2019
@onlymellb onlymellb deleted the clean-pod-schedule-annotation branch September 12, 2019 05:26
@sre-bot sre-bot mentioned this pull request Sep 12, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

cherry pick to release-1.0 in PR #909

onlymellb pushed a commit that referenced this pull request Sep 13, 2019
@sre-bot
Clean pod schedule annotation (#790) (#909)
566f991 
* add retry logic for update pvc

* add pvc cleaner for clean the pod-scheduling annotation

* add e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean pod-scheduling annotation when the last pod was schedueld
5 participants
@onlymellb @tennix @sre-bot @weekface @xiaojingchen