add kind cluster create script #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
reviewed
Aug 20, 2019
cofyc
reviewed
Aug 21, 2019
onlymellb
reviewed
Aug 21, 2019
onlymellb
reviewed
Aug 21, 2019
| echo "init the mount dirs for kind cluster" | ||
| mkdir -p ${data_dir}/worker{,1,2,3,4,5}/vol{1..9} | ||
|
|
||
| cd ${env_dir} |
There was a problem hiding this comment.
Where is this variable defined?
xiaojingchen
changed the title
cofyc
reviewed
Aug 22, 2019
cofyc
reviewed
Aug 22, 2019
tennix
reviewed
Aug 25, 2019
docs/CONTRIBUTING.md
Outdated
| $ ./hack/kind-cluster-v1.12.8.sh | ||
| ``` | ||
|
|
||
| Then you can build and push Docker images to the public Docker registry (There have not docker registry in Kind Kubernetes environment currently) |
There was a problem hiding this comment.
Docker images can be loaded with kind load docker-image or kind load image-archive command.
There was a problem hiding this comment.
this can push images to all nodes, but if ImagePullPolicy is Always, the pod still can not get image from local. it can not resolve the image problem completely
There was a problem hiding this comment.
I think kind load also load image to all nodes. For image always pull issue, can we use IfNotPresent to replace Always.
tennix
reviewed
Aug 25, 2019
tennix
reviewed
Aug 25, 2019
hack/kind-cluster-v1.12.8.sh
Outdated
| - role: control-plane | ||
| - role: worker | ||
| extraPortMappings: | ||
| - containerPort: 5001 |
tennix
reviewed
Aug 25, 2019
tennix
reviewed
Aug 25, 2019
|
/run-e2e-in-kind |
cofyc
reviewed
Aug 27, 2019
cofyc
reviewed
Aug 27, 2019
cofyc
reviewed
Aug 27, 2019
cofyc
reviewed
Aug 27, 2019
cofyc
previously approved these changes
Aug 28, 2019
cofyc
previously approved these changes
Aug 30, 2019
|
/run-e2e-in-kind |
|
@cofyc @tennix @onlymellb PTAL again |
tennix
reviewed
Aug 30, 2019
tennix
reviewed
Sep 1, 2019
tennix
reviewed
Sep 1, 2019
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Closed
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* zh: add 1.1-ga chinese release notes Signed-off-by: Ran <huangran@pingcap.com> * Apply suggestions from code review Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add scripts to create kind cluster env
What is changed and how does it work?
Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: