cleanup of bash scripts #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gregwebs
reviewed
Aug 21, 2019
| fi | ||
|
|
||
| GCLOUD="gcloud --project $PROJECT" | ||
| if ! [[ -d .terraform ]]; then |
There was a problem hiding this comment.
The way the docs are written now, someone would run this before running terraform init. https://pingcap.com/docs/v3.0/tidb-in-kubernetes/deploy/gcp-gke/
There was a problem hiding this comment.
This new approach uses terraform console which is much more reliable. We can update the code snippet in the docs to have terraform init before running this.
gregwebs
reviewed
Aug 21, 2019
| fi | ||
|
|
||
| GCLOUD="gcloud --project $PROJECT" | ||
| if ! [[ -d .terraform ]]; then | ||
| echo "no .terraform directory, perhaps you need to run ''terraform init''?" >&2 |
There was a problem hiding this comment.
All the quoting looked a little odd to me, but no big deal.
gregwebs
approved these changes
Aug 21, 2019
|
I ran this myself. I already have the service account and it properly recognized that. |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR resolves several bash mistakes and brings the scripts in-line with best practices, while adding some new features.
What is changed and how does it work?
Variable expansions are quotes, lowercase variable names are used, tests are cleaned up.
Check List
Tests
I manually tested a number of permutations, including changes to project, removing credentials files, etc.
Does this PR introduce a user-facing change?: