Add stability test for multiple drainers and reparo restore #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
weekface
reviewed
Aug 27, 2019
tests/backup.go
Outdated
| return err | ||
| } | ||
|
|
||
| err = oa.DeployAdHocBackup(from) | ||
| // Restoring via reparo is slow, so we stop inserting data as early as possible to reduce the size of incremental data | ||
| oa.StopInsertDataTo(source) |
There was a problem hiding this comment.
This is not the real use case, the backup must run without stopping insert.
Signed-off-by: Aylei <rayingecho@gmail.com>
|
@weekface Addressed PTAL |
|
/run-e2e-in-kind |
weekface
approved these changes
Aug 28, 2019
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
/run-e2e-tests |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* fix zh/deploy-on-gcp-gke.md as aws * apply suggestions from reviewers * fix as aws doc * change yaml to master version Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
close #748
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?:
No.