fix ad-hoc full backup failure due to incorrect claimName #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielZhangQD
added
type/bug
|
/run-e2e-in-kind |
|
|
|
The |
|
This is a bug, add a release note. |
Users need to specify the name during the restore, the auto-generated name will not be used. |
weekface
approved these changes
Aug 28, 2019
onlymellb
approved these changes
Aug 29, 2019
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 in PR #843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
ad-hoc backup will fail if use default backup name which is not rendered during helm install in backup-job.yaml.
What is changed and how does it work?
Make helm render the backup name.
Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: