add provider and module versions for aws #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-in-kind |
cofyc
reviewed
Sep 18, 2019
| @@ -1,6 +1,7 @@ | |||
| module "eks" { | |||
| source = "terraform-aws-modules/eks/aws" | |||
|
|
|||
| version = "5.1.0" | |||
There was a problem hiding this comment.
This is the version for module terraform-aws-modules/eks/aws.
Each provider and the non-local module is recommended to set the version explicitly:
https://www.terraform.io/docs/configuration/modules.html#module-versions
https://www.terraform.io/docs/configuration/providers.html#version-provider-versions
cofyc
approved these changes
Sep 18, 2019
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 in PR #929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some provider and module versions are missed in terraform scripts for AWS, which may cause new versions with breaking changes will be automatically installed by terraform init in future.
Refer to #895
What is changed and how does it work?
Check List
Tests
Deploy TiDB with terraform on AWS EKS
Code changes
Related changes
Does this PR introduce a user-facing change?: