Set the default externalTrafficPolicy to be Local for TiDB service #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we do this in the terraform deployment script? This looks like a breaking change to the operator. |
|
@weekface: which part/file do you have in mind for "the terraform deployment script"? |
|
@shinnosuke-okada The default values.yaml for terraform module https://github.com/pingcap/tidb-operator/blob/master/deploy/modules/aws/tidb-cluster/values/default.yaml |
|
@aylei PTAL |
|
Users may deploy tidb-cluster in their IDC where a node can have multiple pods scheduled. |
sokada1221
force-pushed
the
local-external-traffic-policy
branch
from
c1dd6af to
d8eeffc
Compare
|
Addressed the review comment. PTAL. |
weekface
approved these changes
Sep 25, 2019
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 in PR #960 |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#879
What is changed and how does it work?
The default externalTrafficPolicy is now set to be Local
Check List
Tests
kubectl describe service my-cluster-tidb -n my-clusterand verify the value of externalTrafficPolicy.Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: