Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pkg about database #142

Merged
merged 10 commits into from
Dec 29, 2018
Merged

update pkg about database #142

merged 10 commits into from
Dec 29, 2018

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Dec 13, 2018 •
edited
Loading

What problem does this PR solve?

update some function about database

this pr is splited from pr: #130
make it easy to review

What is changed and how it works?

  1. add some function to get tidb's buckets info
  2. add some function about index

Check List

Tests

  • Unit test
  • Integration test

@WangXiangUSTC
Copy link
Contributor Author

@GregoryIan @csuzhangxc PTAL

IANTHEREAL
IANTHEREAL reviewed Dec 14, 2018
View reviewed changes
pkg/dbutil/common.go Outdated Show resolved Hide resolved
IANTHEREAL
IANTHEREAL reviewed Dec 14, 2018
View reviewed changes
pkg/dbutil/common.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Dec 14, 2018
View reviewed changes
pkg/dbutil/common.go Outdated Show resolved Hide resolved
pkg/dbutil/common.go Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Dec 14, 2018
View reviewed changes
pkg/dbutil/common.go Outdated Show resolved Hide resolved
pkg/dbutil/common.go Show resolved Hide resolved
@csuzhangxc
Copy link
Member

LGTM, but CI fail with other problem

@WangXiangUSTC
Copy link
Contributor Author

/rebuild

@WangXiangUSTC
Copy link
Contributor Author

WangXiangUSTC commented Dec 24, 2018 •
edited
Loading

ci failed because mysql's port is already bind. rebuild and success. Thanks @csuzhangxc
@GregoryIan PTAL

@WangXiangUSTC
Copy link
Contributor Author

/rebuild

IANTHEREAL
IANTHEREAL reviewed Dec 27, 2018
View reviewed changes
pkg/dbutil/common.go Outdated Show resolved Hide resolved
@IANTHEREAL
Copy link
Collaborator

ping @WangXiangUSTC

@WangXiangUSTC
Copy link
Contributor Author

I am doing this now. @GregoryIan

@WangXiangUSTC
Copy link
Contributor Author

PTAL again @GregoryIan

@IANTHEREAL
Copy link
Collaborator

LGTM

@WangXiangUSTC WangXiangUSTC merged commit 0a7ed9a into pingcap:master Dec 29, 2018
WangXiangUSTC added a commit to WangXiangUSTC/tidb-tools that referenced this pull request Feb 11, 2019
@WangXiangUSTC
update pkg about database (pingcap#142)
e819b7f
@WangXiangUSTC WangXiangUSTC mentioned this pull request Feb 13, 2019
Merged
WangXiangUSTC added a commit that referenced this pull request Feb 13, 2019
@WangXiangUSTC
diff: can use multiple columns to split chunks (#197)
1a02077 
* sync_diff_inspector: fix a misleading regex example in config.toml (#141)

* update pkg about database (#142)

* diff: add database name and table name router (#172)

* simplify the if/else logic (#179)

refactor to simplify the if/else logic

* diff: can use multiple columns to split chunks (#130)

* simplify the if/else logic (#191)
@WangXiangUSTC WangXiangUSTC deleted the xiang/pkg branch July 9, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@csuzhangxc csuzhangxc csuzhangxc left review comments

Assignees
No one assigned
Labels
priority/normal status/LGT2 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @csuzhangxc @IANTHEREAL