address comments

pkg/ddl/ingest/backend_mgr.go

@@ -17,6 +17,7 @@ package ingest
 import (
 	"context"
 	"math"
+	"os"
 	"path/filepath"
 	"strconv"
 	"sync"
@@ -126,7 +127,13 @@ func (m *litBackendCtxMgr) Register(
 	if !ok {
 		return nil, genBackendAllocMemFailedErr(ctx, m.memRoot, jobID)
 	}
-	cfg, err := genConfig(ctx, m.encodeJobSortPath(jobID), m.memRoot, hasUnique, resourceGroupName)
+	sortPath := m.encodeJobSortPath(jobID)
+	err := os.MkdirAll(sortPath, 0700)
+	if err != nil {
+		logutil.Logger(ctx).Error(LitErrCreateDirFail, zap.Error(err))
+		return nil, err
+	}
+	cfg, err := genConfig(ctx, sortPath, m.memRoot, hasUnique, resourceGroupName)
 	if err != nil {
 		logutil.Logger(ctx).Warn(LitWarnConfigError, zap.Int64("job ID", jobID), zap.Error(err))
 		return nil, err

pkg/ddl/ingest/env.go

@@ -110,18 +110,16 @@ func GenIngestTempDataDir() (string, error) {
 	return sortPath, nil
 }
 
-// CleanUpTempDir reads the temp dir and removes the stale index data.
-// This function will get
+// CleanUpTempDir is used to remove the stale index data.
+// This function gets running DDL jobs from `mysql.tidb_ddl_job` and
+// it only removes the folders that related to finished jobs.
 func CleanUpTempDir(ctx context.Context, se sessionctx.Context, path string) {
-	err := os.MkdirAll(path, 0700)
-	if err != nil {
-		logutil.DDLIngestLogger().Error(LitErrCreateDirFail, zap.Error(err))
-		return
-	}
-
 	entries, err := os.ReadDir(path)
 	if err != nil {
-		logutil.DDLIngestLogger().Error(LitErrReadSortPath, zap.Error(err))
+		if strings.Contains(err.Error(), "no such file") {
+			return
+		}
+		logutil.DDLIngestLogger().Warn(LitErrCleanSortPath, zap.Error(err))
 		return
 	}
 	toCheckJobIDs := make(map[int64]struct{}, len(entries))

pkg/ddl/ingest/env_test.go

@@ -67,4 +67,6 @@ func TestLitBackendCtxMgr(t *testing.T) {
 	ingest.CleanUpTempDir(ctx, tk.Session(), sortPath)
 	require.NoDirExists(t, staleJobDir)
 	require.NoDirExists(t, staleJobDir2)
+
+	ingest.CleanUpTempDir(ctx, tk.Session(), "unkown_path")
 }

pkg/ddl/ingest/message.go

@@ -41,7 +41,7 @@ const (
 	LitErrExceedConcurrency string = "the concurrency is greater than ingest limit"
 	LitErrCloseWriterErr    string = "close writer error"
 	LitErrReadSortPath      string = "cannot read sort path"
-	LitErrCleanSortPath     string = "cannot cleanup sort path"
+	LitErrCleanSortPath     string = "clean up temp dir failed"
 	LitErrResetEngineFail   string = "reset engine failed"
 	LitWarnEnvInitFail      string = "initialize environment failed"
 	LitWarnConfigError      string = "build config for backend failed"